Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(RHINENG-6185) Return current org_id #1583

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

fellipeh
Copy link
Contributor

Overview

This PR is being created to address RHINENG-6185.
GET default endpoint now returns current org_id

PR Checklist

  • Keep PR title short, ideally under 72 characters
  • Descriptive comments provided in complex code blocks
  • Tests: validate optimal/expected output
  • Tests: validate exceptions and failure scenarios
  • Tests: edge cases
  • Recovers or fails gracefully during potential resource outages (e.g. DB, Kafka)
  • Uses type hinting, if convenient
  • Documentation, if this PR changes the way other services interact with host inventory
  • Links to related PRs

Secure Coding Practices Documentation Reference

You can find documentation on this checklist here.

Secure Coding Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

@fellipeh fellipeh requested a review from a team as a code owner December 19, 2023 16:30
@fellipeh fellipeh force-pushed the RHINENG-6185 branch 2 times, most recently from 8edfddd to 73cddb6 Compare December 19, 2023 16:59
@jpramos123 jpramos123 self-requested a review December 19, 2023 17:34
Copy link
Contributor

@jpramos123 jpramos123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review unit tests that are failing!

Thanks

api/staleness_query.py Outdated Show resolved Hide resolved
jpramos123
jpramos123 previously approved these changes Dec 20, 2023
GET `default` endpoint now returns current org_id

Signed-off-by: Fellipe Henrique <[email protected]>
@jpramos123 jpramos123 merged commit 395dc1d into RedHatInsights:master Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants